Remove the hack in the grammar that "optimized away" DEFAULT NULL clauses.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: b17b7fae8c1418f924915348afaa2250d1360bc4
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2007-10-29T19:40:40Z
Releases: 8.3.0
Remove the hack in the grammar that "optimized away" DEFAULT NULL clauses.
Instead put in a test to drop a NULL default at the last moment before
storing the catalog entry.  This changes the behavior in a couple of ways:
* Specifying DEFAULT NULL when creating an inheritance child table will
  successfully suppress inheritance of any default expression from the
  parent's column, where formerly it failed to do so.
* Specifying DEFAULT NULL for a column of a domain type will correctly
  override any default belonging to the domain; likewise for a sub-domain.
The latter change happens because by the time the clause is checked,
it won't be a simple null Const but a CoerceToDomain expression.

Personally I think this should be back-patched, but there doesn't seem to
be consensus for that on pgsql-hackers, so refraining.

Files