Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD.
Tom Lane <tgl@sss.pgh.pa.us>
Select appropriate PG_PRINTF_ATTRIBUTE for recent NetBSD. NetBSD-current generates a large number of warnings about "%m" not being appropriate to use with *printf functions. While that's true for their native printf, it's surely not true for snprintf.c, so I think they have misunderstood gcc's definition of the "gnu_printf" archetype. Nonetheless, choosing "__syslog__" instead silences the warnings; so teach configure about that. Since this is only a cosmetic warning issue (and anyway it depends on previous hacking to be self-consistent), no back-patch. Discussion: https://postgr.es/m/16785.1539046036@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| config/c-compiler.m4 | modified | +25 −10 |
| configure | modified | +35 −6 |
| src/include/pg_config.h.in | modified | +1 −1 |
Discussion
- Allowing printf("%m") only where it actually works 50 messages · 2018-05-21 → 2018-10-09