Add --buffer-usage-limit option to vacuumdb
David Rowley <drowley@postgresql.org>
Add --buffer-usage-limit option to vacuumdb 1cbbee033 added BUFFER_USAGE_LIMIT to the VACUUM and ANALYZE commands, so here we permit that option to be specified in vacuumdb. In passing, adjust the documents for vacuum_buffer_usage_limit and the BUFFER_USAGE_LIMIT VACUUM option to mention "kB" rather than "KB". Do the same for the ERROR message in ExecVacuum() and check_vacuum_buffer_usage_limit(). Without that we might tell a user that the valid minimum value is 128 KB only to reject that because we accept only "kB" and not "KB". Also, add a small reminder comment in vacuum.h to try to trigger the memory of anyone adding new fields to VacuumParams that they might want to consider if vacuumdb needs to grow a new option too. Author: Melanie Plageman Reviewed-by: Justin Pryzby Reviewed-by: David Rowley Discussion: https://postgr.es/m/ZAzTg3iEnubscvbf@telsasoft.com
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/config.sgml | modified | +2 −2 |
| doc/src/sgml/ref/vacuumdb.sgml | modified | +13 −0 |
| src/backend/commands/vacuum.c | modified | +2 −2 |
| src/bin/scripts/vacuumdb.c | modified | +26 −0 |
| src/include/commands/vacuum.h | modified | +3 −0 |
| src/test/regress/expected/vacuum.out | modified | +2 −2 |
Documentation touched
Discussion
- Option to not use ringbuffer in VACUUM, using it in failsafe mode 79 messages · 2023-01-11 → 2023-04-28