Fix race in SSI interaction with empty btrees.
Thomas Munro <tmunro@postgresql.org>
Fix race in SSI interaction with empty btrees. When predicate-locking btrees, we have a special case for completely empty btrees, since there is no page to lock. This was racy, because, without buffer lock held, a matching key could be inserted between the _bt_search() and the PredicateLockRelation() calls. Fix, by rechecking _bt_search() after taking the relation-level SIREAD lock, if using SERIALIZABLE isolation and an empty btree is discovered. Back-patch to all supported releases. Fixes one aspect of bug #17949. Reported-by: Artem Anisimov <artem.anisimov.255@gmail.com> Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Discussion: https://postgr.es/m/17949-a0f17035294a55e2%40postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/nbtree/nbtsearch.c | modified | +26 −13 |
Discussion
- BUG #17949: Adding an index introduces serialisation anomalies. 27 messages · 2023-05-28 → 2023-07-16