Revert error handling improvements for cryptohashes
Michael Paquier <michael@paquier.xyz>
Revert error handling improvements for cryptohashes This reverts commits ab27df2, af8d530 and 3a0cced, that introduced pg_cryptohash_error(). In order to make the core code able to pass down the new error types that this introduced, some of the MD5-related routines had to be reworked, causing an ABI breakage, but we found that some external extensions rely on them. Maintaining compatibility outweights the error report benefits, so just revert the change in v14. Reported-by: Laurenz Albe Discussion: https://postgr.es/m/9f0c0a96d28cf14fc87296bbe67061c14eb53ae8.camel@cybertec.at
Files
| Path | Change | +/− |
|---|---|---|
| contrib/passwordcheck/passwordcheck.c | modified | +1 −1 |
| contrib/pgcrypto/internal.c | modified | +6 −12 |
| contrib/pgcrypto/internal-sha2.c | modified | +3 −6 |
| contrib/uuid-ossp/uuid-ossp.c | modified | +6 −12 |
| src/backend/commands/user.c | modified | +2 −2 |
| src/backend/libpq/auth.c | modified | +15 −21 |
| src/backend/libpq/auth-scram.c | modified | +1 −1 |
| src/backend/libpq/crypt.c | modified | +21 −17 |
| src/backend/replication/backup_manifest.c | modified | +3 −6 |
| src/backend/utils/adt/cryptohashfuncs.c | modified | +9 −16 |
| src/common/cryptohash.c | modified | +1 −56 |
| src/common/cryptohash_openssl.c | modified | +0 −93 |
| src/common/md5_common.c | modified | +5 −15 |
| src/include/common/cryptohash.h | modified | +0 −1 |
| src/include/common/md5.h | modified | +3 −6 |
| src/include/libpq/crypt.h | modified | +3 −4 |
| src/include/libpq/scram.h | modified | +1 −2 |
| src/interfaces/libpq/fe-auth.c | modified | +8 −25 |
| src/tools/pgindent/typedefs.list | modified | +0 −1 |
Discussion
Cited messages not in the archive:
9f0c0a96d28cf14fc87296bbe67061c14eb53ae8.camel@cybertec.at