Use LOCKMODE in parse_relation.c/.h
Peter Eisentraut <peter@eisentraut.org>
Author:
Peter Eisentraut <peter@eisentraut.org>
Date: 2026-02-23T20:25:55Z
Releases:
19 (unreleased)
Use LOCKMODE in parse_relation.c/.h There were a couple of comments in parse_relation.c > Note: properly, lockmode should be declared LOCKMODE not int, but that > would require importing storage/lock.h into parse_relation.h. Since > LOCKMODE is typedef'd as int anyway, that seems like overkill. but actually LOCKMODE has been in storage/lockdefs.h for a while, which is intentionally a more narrow header. So we can include that one in parse_relation.h and just use LOCKMODE normally. An alternative would be to add a duplicate typedef into parse_relation.h, but that doesn't seem necessary here. Reviewed-by: Andreas Karlsson <andreas@proxel.se> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/4bcd65fb-2497-484c-bb41-83cb435eb64d%40eisentraut.org
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/parser/parse_relation.c | modified | +2 −10 |
| src/include/parser/parse_relation.h | modified | +3 −2 |
Discussion
- Use LOCKMODE in parse_relation.c/.h 5 messages · 2026-02-18 → 2026-02-23