Disallow NaN as a value for floating-point GUCs.
Tom Lane <tgl@sss.pgh.pa.us>
Disallow NaN as a value for floating-point GUCs. None of the code that uses GUC values is really prepared for them to hold NaN, but parse_real() didn't have any defense against accepting such a value. Treat it the same as a syntax error. I haven't attempted to analyze the exact consequences of setting any of the float GUCs to NaN, but since they're quite unlikely to be good, this seems like a back-patchable bug fix. Note: we don't need an explicit test for +-Infinity because those will be rejected by existing range checks. I added a regression test for that in HEAD, but not older branches because the spelling of the value in the error message will be platform-dependent in branches where we don't always use port/snprintf.c. Discussion: https://postgr.es/m/1798.1552165479@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/utils/misc/guc.c | modified | +4 −0 |
| src/test/regress/expected/guc.out | modified | +7 −0 |
| src/test/regress/sql/guc.sql | modified | +5 −0 |
Discussion
- Should we increase the default vacuum_cost_limit? 44 messages · 2019-02-25 → 2019-03-12