Horton

Move privilege check to the right place

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: ac22a9545ca906e70a819b54e76de38817c93aaf
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-09-07T10:15:18Z
Releases: 17.0 
Move privilege check to the right place

Now that ATExecDropConstraint doesn't recurse anymore, so it's wrong to
test privileges "during recursion" there.  Move the check to
dropconstraint_internal, which is the place where recursion occurs.

In passing, remove now-useless 'recursing' argument to
ATExecDropConstraint.

Discussion: https://postgr.es/m/202309051744.y4mndw5gwzhh@alvherre.pgsql

Files

PathChange+/−
src/backend/commands/tablecmds.c modified +8 −10
src/test/regress/expected/inherit.out modified +21 −0
src/test/regress/sql/inherit.sql modified +21 −0

Discussion