Rename RBTXN_PREPARE to RBTXN_IS_PREPARE for better clarification.
Masahiko Sawada <msawada@postgresql.org>
Rename RBTXN_PREPARE to RBTXN_IS_PREPARE for better clarification. RBTXN_PREPARE flag and rbtxn_prepared macro could be misinterpreted as either indicating the transaction type (e.g. a prepared transaction or a normal transaction) or its currentstate (e.g. skipped or its prepare message is sent), especially after commit 072ee847ad4 introduced the RBTXN_SENT_PREPARE flag and the rbtxn_sent_prepare macro. The RBTXN_PREPARE flag (and its corresponding macro) have been renamed to RBTXN_IS_PREPARE to explicitly indicate the transaction type. Therefore, this commit also adds the RBTXN_IS_PREPARE flag to the transaction that is a prepared transaction and has been skipped, which previously had only the RBTXN_SKIPPED_PREPARE flag. Reviewed-by: Amit Kapila, Peter Smith Discussion: https://postgr.es/m/CAA4eK1KgNmBsG%3D155E7QQ6TX9RoWnM4z5Z20SvsbwxSe_QXYsg%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/replication/logical/proto.c | modified | +1 −1 |
| src/backend/replication/logical/reorderbuffer.c | modified | +31 −19 |
| src/backend/replication/logical/snapbuild.c | modified | +1 −1 |
| src/include/replication/reorderbuffer.h | modified | +5 −3 |
Discussion
- Skip collecting decoded changes of already-aborted transactions 84 messages · 2023-06-09 → 2025-03-17