Horton

Pass ItemPointer not HeapTuple to IndexBuildCallback.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: aae50236e4ce95c05a3962be0814c74c5a22206d
Author: Andres Freund <andres@anarazel.de>
Date: 2019-11-08T19:49:29Z
Releases: 13.0 
Pass ItemPointer not HeapTuple to IndexBuildCallback.

Not all AMs use HeapTuples internally, making it inconvenient to pass
a HeapTuple. As the index callbacks really only need the TID, not the
full tuple, modify callback to only take ItemPointer.

Author: Ashwin Agrawal
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeis6=8ehuR=VNtHvj3z16cYfCwPdTcpaxU+sfSUJ5QgR3g@mail.gmail.com

Files

PathChange+/−
contrib/amcheck/verify_nbtree.c modified +3 −3
contrib/bloom/blinsert.c modified +2 −2
src/backend/access/brin/brin.c modified +2 −2
src/backend/access/gin/gininsert.c modified +2 −3
src/backend/access/gist/gistbuild.c modified +3 −3
src/backend/access/hash/hash.c modified +4 −5
src/backend/access/heap/heapam_handler.c modified +6 −7
src/backend/access/nbtree/nbtsort.c modified +4 −4
src/backend/access/spgist/spginsert.c modified +2 −2
src/include/access/tableam.h modified +1 −1

Discussion