Restructure parsetree representation of DECLARE CURSOR: now it's a

Tom Lane <tgl@sss.pgh.pa.us>

Commit: aa83bc04e089e13f2746ba55720e5993268c46f5
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2003-03-10T03:53:52Z
Releases: 7.4.1
Restructure parsetree representation of DECLARE CURSOR: now it's a
utility statement (DeclareCursorStmt) with a SELECT query dangling from
it, rather than a SELECT query with a few unusual fields in it.  Add
code to determine whether a planned query can safely be run backwards.
If DECLARE CURSOR specifies SCROLL, ensure that the plan can be run
backwards by adding a Materialize plan node if it can't.  Without SCROLL,
you get an error if you try to fetch backwards from a cursor that can't
handle it.  (There is still some discussion about what the exact
behavior should be, but this is necessary infrastructure in any case.)
Along the way, make EXPLAIN DECLARE CURSOR work.

Files

PathChange+/−
doc/src/sgml/ref/declare.sgml modified +26 −20
doc/src/sgml/ref/explain.sgml modified +3 −2
doc/src/sgml/ref/fetch.sgml modified +14 −8
doc/src/sgml/ref/move.sgml modified +2 −4
doc/src/sgml/ref/prepare.sgml modified +10 −1
src/backend/commands/explain.c modified +33 −16
src/backend/commands/portalcmds.c modified +167 −41
src/backend/executor/execAmi.c modified +59 −1
src/backend/executor/execMain.c modified +2 −4
src/backend/executor/spi.c modified +11 −93
src/backend/nodes/copyfuncs.c modified +15 −5
src/backend/nodes/equalfuncs.c modified +14 −5
src/backend/nodes/outfuncs.c modified +15 −3
src/backend/nodes/readfuncs.c modified +20 −5
src/backend/optimizer/path/allpaths.c modified +2 −3
src/backend/optimizer/plan/createplan.c modified +36 −1
src/backend/optimizer/plan/planmain.c modified +2 −5
src/backend/optimizer/plan/planner.c modified +33 −30
src/backend/optimizer/plan/subselect.c modified +3 −25
src/backend/optimizer/prep/prepjointree.c modified +2 −3
src/backend/optimizer/prep/prepunion.c modified +2 −3
src/backend/optimizer/util/clauses.c modified +1 −2
src/backend/parser/analyze.c modified +34 −56
src/backend/parser/gram.y modified +59 −68
src/backend/parser/parse_clause.c modified +2 −2
src/backend/parser/parse_type.c modified +1 −2
src/backend/tcop/postgres.c modified +7 −3
src/backend/tcop/pquery.c modified +6 −95
src/backend/tcop/utility.c modified +7 −3
src/backend/utils/mmgr/portalmem.c modified +14 −3
src/include/catalog/catversion.h modified +2 −2
src/include/commands/portalcmds.h modified +8 −15
src/include/executor/executor.h modified +2 −1
src/include/executor/spi.h modified +3 −2
src/include/nodes/nodes.h modified +2 −1
src/include/nodes/parsenodes.h modified +33 −22
src/include/optimizer/planmain.h modified +2 −1
src/include/optimizer/planner.h modified +2 −2
src/include/tcop/pquery.h modified +1 −4
src/include/utils/portal.h modified +4 −9