Fix broken error check in _hash_doinsert.

Robert Haas <rhaas@postgresql.org>

Commit: aa04e5c3c1b1ba27d5e726d9afc291f475051ec0
Author: Robert Haas <rhaas@postgresql.org>
Date: 2016-12-22T19:03:07Z
Releases: 9.5.6
Fix broken error check in _hash_doinsert.

You can't just cast a HashMetaPage to a Page, because the meta page
data is stored after the page header, not at offset 0.  Fortunately,
this didn't break anything because it happens to find hashm_bsize
at the offset at which it expects to find pd_pagesize_version, and
the values are close enough to the same that this works out.

Still, it's a bug, so back-patch to all supported versions.

Mithun Cy, revised a bit by me.

Files

PathChange+/−
src/backend/access/hash/hashinsert.c modified +5 −3