Fix json_to_record() bug with nested objects.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: a9d199f6d3b998929cdb8e8aa61e5cd8db9b220f
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2016-03-03T04:31:39Z
Releases: 9.6.0
Fix json_to_record() bug with nested objects.

A thinko concerning nesting depth caused json_to_record() to produce bogus
output if a field of its input object contained a sub-object with a field
name matching one of the requested output column names.  Per bug #13996
from Johann Visagie.

I added a regression test case based on his example, plus parallel tests
for json_to_recordset, jsonb_to_record, jsonb_to_recordset.  The latter
three do not exhibit the same bug (which suggests that we may be missing
some opportunities to share code...) but testing seems like a good idea
in any case.

Back-patch to 9.4 where these functions were introduced.

Files