Fix the missing table sync due to improper invalidation handling.
Amit Kapila <akapila@postgresql.org>
Fix the missing table sync due to improper invalidation handling. We missed performing table sync if the invalidation happened while the non-ready tables list was being prepared. This occurs because the sync state was set to valid at the end of non-ready table list preparation irrespective of the invalidations processed while the list is being prepared. Fix it by changing the boolean variable to a tri-state enum and by setting table state to valid only if no invalidations have occurred while the list is being prepared. Reprted-by: Alexander Lakhin Diagnosed-by: Alexander Lakhin Author: Vignesh C Reviewed-by: Hou Zhijie, Alexander Lakhin, Ajin Cherian, Amit Kapila Backpatch-through: 15 Discussion: https://postgr.es/m/711a6afe-edb7-1211-cc27-1bef8239eec7@gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/replication/logical/tablesync.c | modified | +21 −4 |
| src/tools/pgindent/typedefs.list | modified | +1 −0 |
Discussion
- Race condition in FetchTableStates() breaks synchronization of subscription tables 25 messages · 2024-01-26 → 2024-04-29