pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

Michael Paquier <michael@paquier.xyz>

Commit: a8dd62ef4959141e410278fd68b3d1821e0bbbaa
Author: Michael Paquier <michael@paquier.xyz>
Date: 2023-12-19T06:20:39Z
Releases: 17.0
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

As coded, the function relied on index_open() when opening an index
relation, allowing partitioned indexes to be processed by
pgstathashindex().  This was leading to a "could not open file" error
because partitioned indexes have no physical files, or to a crash with
an assertion failure (like on HEAD).

This issue is fixed by applying the same checks as the other stat
functions for indexes, with a lookup at both RELKIND_INDEX and the index
AM expected.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org
Backpatch-through: 12

Files

Discussion