Fix inconsistent equalfuncs.c behavior for FuncCall.funcformat.

Tom Lane <tgl@sss.pgh.pa.us>

Commit: a65e9f3f1405b786673feec131879843432bf9a6
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-06-06T19:46:58Z
Releases: 14.0
Fix inconsistent equalfuncs.c behavior for FuncCall.funcformat.

Other equalfuncs.c checks on CoercionForm fields use
COMPARE_COERCIONFORM_FIELD (which makes them no-ops),
but commit 40c24bfef neglected to make _equalFuncCall
do likewise.  Fix that.

This is only strictly correct if FuncCall.funcformat has
no semantic effect, instead just determining ruleutils.c
display formatting.  40c24bfef added a couple of checks
in parse analysis that could break that rule; but on closer
inspection, they're redundant, so just take them out again.

Per report from Noah Misch.

Discussion: https://postgr.es/m/20210606063331.GC297923@rfd.leadboat.com

Files

Discussion