Horton

Harmonize more parameter names in bulk.

Peter Geoghegan <pg@bowt.ie>

View on postgr.es
Commit: a601366a460f68472bf70c4d94c57baa0a3ed1b2
Author: Peter Geoghegan <pg@bowt.ie>
Date: 2022-09-20T20:09:30Z
Releases: 16.0 
Harmonize more parameter names in bulk.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in optimizer, parser,
utility, libpq, and "commands" code, as well as in remaining library
code.  Do the same for all code related to frontend programs (with the
exception of pg_dump/pg_dumpall related code).

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.  Later commits will handle
ecpg and pg_dump/pg_dumpall.

Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Files

PathChange+/−
src/backend/backup/basebackup.c modified +1 −1
src/backend/bootstrap/bootstrap.c modified +5 −5
src/backend/commands/event_trigger.c modified +1 −1
src/backend/commands/explain.c modified +1 −1
src/backend/commands/indexcmds.c modified +1 −1
src/backend/commands/lockcmds.c modified +1 −1
src/backend/commands/opclasscmds.c modified +1 −1
src/backend/commands/schemacmds.c modified +3 −3
src/backend/commands/tablecmds.c modified +3 −3
src/backend/commands/trigger.c modified +4 −4
src/backend/lib/dshash.c modified +1 −1
src/backend/lib/integerset.c modified +2 −2
src/backend/libpq/be-secure-openssl.c modified +2 −2
src/backend/optimizer/geqo/geqo_selection.c modified +1 −1
src/backend/optimizer/plan/createplan.c modified +1 −1
src/backend/optimizer/plan/planner.c modified +2 −2
src/backend/optimizer/util/plancat.c modified +2 −1
src/backend/parser/gram.y modified +1 −2
src/backend/parser/parse_clause.c modified +1 −1
src/backend/parser/parse_utilcmd.c modified +1 −1
src/backend/partitioning/partbounds.c modified +3 −3
src/backend/postmaster/postmaster.c modified +3 −3
src/backend/statistics/extended_stats.c modified +2 −2
src/backend/utils/adt/datetime.c modified +11 −11
src/backend/utils/adt/geo_ops.c modified +4 −4
src/backend/utils/adt/jsonb.c modified +6 −6
src/backend/utils/adt/jsonb_util.c modified +37 −37
src/backend/utils/adt/jsonpath_exec.c modified +1 −1
src/backend/utils/adt/like.c modified +2 −2
src/backend/utils/adt/numeric.c modified +3 −3
src/backend/utils/adt/rangetypes.c modified +2 −2
src/backend/utils/adt/ri_triggers.c modified +1 −1
src/backend/utils/adt/timestamp.c modified +2 −2
src/backend/utils/adt/xml.c modified +1 −1
src/backend/utils/cache/relmapper.c modified +1 −1
src/backend/utils/error/elog.c modified +1 −1
src/backend/utils/misc/guc.c modified +1 −1
src/backend/utils/misc/queryjumble.c modified +2 −1
src/backend/utils/sort/tuplesortvariants.c modified +1 −1
src/backend/utils/time/snapmgr.c modified +15 −14
src/bin/initdb/initdb.c modified +1 −1
src/bin/pg_amcheck/pg_amcheck.c modified +1 −1
src/bin/pg_basebackup/pg_receivewal.c modified +1 −1
src/bin/pg_basebackup/streamutil.h modified +1 −1
src/bin/pg_basebackup/walmethods.h modified +4 −4
src/bin/pgbench/pgbench.h modified +4 −4
src/bin/pg_rewind/file_ops.h modified +2 −2
src/bin/pg_rewind/pg_rewind.h modified +1 −1
src/bin/pg_upgrade/info.c modified +1 −1
src/bin/pg_upgrade/pg_upgrade.h modified +1 −1
src/bin/pg_upgrade/relfilenumber.c modified +1 −1
src/bin/pg_verifybackup/pg_verifybackup.c modified +1 −1
src/bin/pg_waldump/compat.c modified +3 −3
src/bin/psql/describe.h modified +3 −3
src/bin/scripts/common.h modified +1 −1
src/fe_utils/cancel.c modified +2 −2
src/include/bootstrap/bootstrap.h modified +2 −2
src/include/commands/alter.h modified +1 −1
src/include/commands/conversioncmds.h modified +1 −1
src/include/commands/matview.h modified +1 −1
src/include/commands/policy.h modified +1 −1
src/include/commands/publicationcmds.h modified +1 −1
src/include/commands/schemacmds.h modified +2 −2
src/include/commands/seclabel.h modified +1 −1
src/include/commands/sequence.h modified +4 −4
src/include/commands/tablecmds.h modified +1 −1
src/include/commands/tablespace.h modified +2 −2
src/include/commands/trigger.h modified +7 −7
src/include/commands/typecmds.h modified +1 −1
src/include/common/fe_memutils.h modified +2 −2
src/include/common/kwlookup.h modified +1 −1
src/include/common/scram-common.h modified +1 −1
src/include/fe_utils/cancel.h modified +1 −1
src/include/fe_utils/mbprint.h modified +2 −1
src/include/fe_utils/parallel_slot.h modified +1 −1
src/include/fe_utils/recovery_gen.h modified +1 −1
src/include/fe_utils/simple_list.h modified +1 −1
src/include/fe_utils/string_utils.h modified +1 −1
src/include/foreign/foreign.h modified +3 −2
src/include/funcapi.h modified +1 −1
src/include/libpq/pqmq.h modified +1 −1
src/include/nodes/extensible.h modified +2 −2
src/include/nodes/nodes.h modified +1 −1
src/include/nodes/params.h modified +2 −2
src/include/nodes/pg_list.h modified +2 −2
src/include/nodes/value.h modified +1 −1
src/include/optimizer/appendinfo.h modified +1 −1
src/include/optimizer/clauses.h modified +2 −2
src/include/optimizer/cost.h modified +2 −2
src/include/optimizer/paths.h modified +2 −2
src/include/optimizer/planmain.h modified +1 −1
src/include/optimizer/prep.h modified +1 −1
src/include/parser/analyze.h modified +1 −1
src/include/parser/parse_agg.h modified +1 −1
src/include/parser/parse_oper.h modified +2 −2
src/include/parser/parse_relation.h modified +1 −1
src/include/partitioning/partbounds.h modified +2 −2
src/include/pgstat.h modified +5 −5
src/include/pgtime.h modified +2 −2
src/include/port.h modified +4 −4
src/include/postmaster/bgworker.h modified +1 −1
src/include/postmaster/syslogger.h modified +1 −1
src/include/rewrite/rewriteManip.h modified +1 −1
src/include/snowball/libstemmer/header.h modified +1 −1
src/include/statistics/extended_stats_internal.h modified +1 −1
src/include/statistics/statistics.h modified +2 −2
src/include/tcop/cmdtag.h modified +1 −1
src/include/tsearch/ts_utils.h modified +2 −2
src/include/utils/acl.h modified +3 −3
src/include/utils/attoptcache.h modified +1 −1
src/include/utils/builtins.h modified +4 −4
src/include/utils/datetime.h modified +1 −1
src/include/utils/jsonb.h modified +3 −3
src/include/utils/multirangetypes.h modified +3 −3
src/include/utils/numeric.h modified +1 −1
src/include/utils/pgstat_internal.h modified +2 −2
src/include/utils/rangetypes.h modified +2 −2
src/include/utils/regproc.h modified +1 −1
src/include/utils/relcache.h modified +1 −1
src/include/utils/relmapper.h modified +1 −1
src/include/utils/selfuncs.h modified +2 −2
src/include/utils/snapmgr.h modified +1 −1
src/include/utils/timestamp.h modified +2 −2
src/include/utils/tuplesort.h modified +1 −1
src/include/utils/xml.h modified +1 −1
src/interfaces/libpq/fe-connect.c modified +1 −1
src/interfaces/libpq/fe-exec.c modified +11 −11
src/interfaces/libpq/fe-secure-common.h modified +2 −2
src/interfaces/libpq/fe-secure-openssl.c modified +2 −2
src/interfaces/libpq/libpq-fe.h modified +2 −2
src/pl/plpgsql/src/pl_exec.c modified +1 −1

Discussion