Avoid making commutatively-duplicate clauses in EquivalenceClasses.
Tom Lane <tgl@sss.pgh.pa.us>
Avoid making commutatively-duplicate clauses in EquivalenceClasses. When we decide we need to make a derived clause equating a.x and b.y, we already will re-use a previously-made clause "a.x = b.y". But we might instead have "b.y = a.x", which is perfectly usable because equivclass.c has never promised anything about the operand order in clauses it builds. Saving construction of a new RestrictInfo doesn't matter all that much in itself --- but because we cache selectivity estimates and so on per-RestrictInfo, there's a possibility of saving a fair amount of duplicative effort downstream. Hence, check for commutative matches as well as direct ones when seeing if we have a pre-existing clause. This changes the visible clause order in several regression test cases, but they're all clearly-insignificant changes. Checking for the reverse operand order is simple enough, but if we wanted to check for operator OID match we'd need to call get_commutator here, which is not so cheap. I concluded that we don't really need the operator check anyway, so I just removed it. It's unlikely that an opfamily contains more than one applicable operator for a given pair of operand datatypes; and if it does they had better give the same answers, so there seems little need to insist that we use exactly the one select_equality_operator chose. Using the current core regression suite as a test case, I see this change reducing the number of new join clauses built by create_join_clause from 9673 to 5142 (out of 26652 calls). So not quite 50% savings, but pretty close to it. Discussion: https://postgr.es/m/78062.1666735746@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| contrib/postgres_fdw/expected/postgres_fdw.out | modified | +26 −26 |
| src/backend/optimizer/path/equivclass.c | modified | +20 −8 |
| src/test/regress/expected/join.out | modified | +5 −5 |
| src/test/regress/expected/partition_join.out | modified | +7 −7 |
| src/test/regress/expected/tidscan.out | modified | +1 −1 |
Discussion
- Reducing duplicativeness of EquivalenceClass-derived clauses 6 messages · 2022-10-25 → 2022-10-27