Horton

Remove PointerIsValid()

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: a5b35fcedb542587e7d8b8fcd21a2e0995b82d2f
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2025-09-24T13:17:20Z
Releases: 19 (unreleased) 
Remove PointerIsValid()

This doesn't provide any value over the standard style of checking the
pointer directly or comparing against NULL.

Also remove related:
- AllocPointerIsValid() [unused]
- IndexScanIsValid() [had one user]
- HeapScanIsValid() [unused]
- InvalidRelation [unused]

Leaving HeapTupleIsValid(), ItemIdIsValid(), PortalIsValid(),
RelationIsValid for now, to reduce code churn.

Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com>
Discussion: https://www.postgresql.org/message-id/flat/ad50ab6b-6f74-4603-b099-1cd6382fb13d%40eisentraut.org
Discussion: https://www.postgresql.org/message-id/CA+hUKG+NFKnr=K4oybwDvT35dW=VAjAAfiuLxp+5JeZSOV3nBg@mail.gmail.com
Discussion: https://www.postgresql.org/message-id/bccf2803-5252-47c2-9ff0-340502d5bd1c@iki.fi

Files

PathChange+/−
src/backend/access/common/reloptions.c modified +4 −4
src/backend/access/common/tupdesc.c modified +5 −5
src/backend/access/index/indexam.c modified +3 −3
src/backend/access/transam/xact.c modified +9 −9
src/backend/catalog/index.c modified +4 −4
src/backend/catalog/objectaddress.c modified +1 −1
src/backend/catalog/pg_proc.c modified +1 −1
src/backend/catalog/pg_type.c modified +1 −1
src/backend/commands/foreigncmds.c modified +7 −7
src/backend/commands/tablecmds.c modified +2 −2
src/backend/nodes/outfuncs.c modified +1 −1
src/backend/postmaster/autovacuum.c modified +1 −1
src/backend/storage/ipc/sinvaladt.c modified +1 −1
src/backend/storage/large_object/inv_api.c modified +7 −7
src/backend/utils/adt/acl.c modified +1 −1
src/backend/utils/adt/arrayfuncs.c modified +1 −1
src/backend/utils/adt/datum.c modified +2 −2
src/backend/utils/adt/xml.c modified +1 −1
src/backend/utils/cache/catcache.c modified +1 −1
src/backend/utils/cache/relcache.c modified +2 −2
src/backend/utils/cache/syscache.c modified +12 −20
src/backend/utils/error/assert.c modified +1 −2
src/backend/utils/mmgr/aset.c modified +2 −8
src/backend/utils/mmgr/bump.c modified +1 −1
src/backend/utils/mmgr/generation.c modified +2 −2
src/backend/utils/mmgr/portalmem.c modified +9 −9
src/backend/utils/mmgr/slab.c modified +2 −2
src/include/access/genam.h modified +0 −6
src/include/access/heapam.h modified +0 −6
src/include/access/htup.h modified +1 −1
src/include/access/itup.h modified +1 −1
src/include/c.h modified +0 −6
src/include/lib/radixtree.h modified +1 −1
src/include/storage/itemid.h modified +1 −1
src/include/storage/itemptr.h modified +7 −7
src/include/utils/portal.h modified +1 −1
src/include/utils/rel.h modified +1 −3

Discussion