Field conninfo strings throughout src/bin/scripts.

Noah Misch <noah@leadboat.com>

Commit: a466ea33c0acbf9938144ffd9eecdabbb69e8f46
Author: Noah Misch <noah@leadboat.com>
Date: 2016-08-08T14:07:52Z
Releases: 9.2.18
Field conninfo strings throughout src/bin/scripts.

These programs nominally accepted conninfo strings, but they would
proceed to use the original dbname parameter as though it were an
unadorned database name.  This caused "reindexdb dbname=foo" to issue an
SQL command that always failed, and other programs printed a conninfo
string in error messages that purported to print a database name.  Fix
both problems by using PQdb() to retrieve actual database names.
Continue to print the full conninfo string when reporting a connection
failure.  It is informative there, and if the database name is the sole
problem, the server-side error message will include the name.  Beyond
those user-visible fixes, this allows a subsequent commit to synthesize
and use conninfo strings without that implementation detail leaking into
messages.  As a side effect, the "vacuuming database" message now
appears after, not before, the connection attempt.  Back-patch to 9.1
(all supported versions).

Reviewed by Michael Paquier and Peter Eisentraut.

Security: CVE-2016-5424

Files

PathChange+/−
src/bin/scripts/clusterdb.c modified +2 −2
src/bin/scripts/createlang.c modified +2 −2
src/bin/scripts/droplang.c modified +2 −2
src/bin/scripts/reindexdb.c modified +12 −12
src/bin/scripts/vacuumdb.c modified +2 −2