Horton

Improve test coverage of geometric types

Tomas Vondra <tomas.vondra@postgresql.org>

View on postgr.es
Commit: a3d2844852dc664718320b15cbc6d6bfa264e66e
Author: Tomas Vondra <tomas.vondra@postgresql.org>
Date: 2018-09-26T08:45:21Z
Releases: 12.0 
Improve test coverage of geometric types

This commit significantly increases test coverage of geo_ops.c, adding
tests for various issues addressed by 2e2a392de3 (which went undetected
for a long time, at least partially due to not being covered).

This also removes alternative results expecting -0 on some platforms.
Instead the functions are should return the same results everywhere,
transforming -0 to 0 if needed.

The tests are added to geometric.sql file, sorted by the left hand side
of the operators. There are many cross datatype operators, so this seems
like the best solution.

Author: Emre Hasegeli
Reviewed-by: Tomas Vondra

Discussion: https://www.postgresql.org/message-id/CAE2gYzxF7-5djV6-cEvqQu-fNsnt%3DEqbOURx7ZDg%2BVv6ZMTWbg%40mail.gmail.com

Files

PathChange+/−
src/test/regress/expected/box.out modified +33 −11
src/test/regress/expected/circle.out modified +31 −8
src/test/regress/expected/create_index.out modified +44 −29
src/test/regress/expected/geometry_1.out modified +4604 −277
src/test/regress/expected/geometry_2.out deleted +0 −563
src/test/regress/expected/geometry.out modified +4604 −277
src/test/regress/expected/line.out modified +44 −228
src/test/regress/expected/lseg.out modified +8 −16
src/test/regress/expected/path.out modified +26 −23
src/test/regress/expected/point.out modified +241 −117
src/test/regress/expected/polygon.out modified +9 −191
src/test/regress/sql/box.sql modified +9 −0
src/test/regress/sql/circle.sql modified +9 −1
src/test/regress/sql/geometry.sql modified +377 −23
src/test/regress/sql/line.sql modified +17 −62
src/test/regress/sql/lseg.sql modified +4 −5
src/test/regress/sql/path.sql modified +14 −8
src/test/regress/sql/point.sql modified +10 −0
src/test/regress/sql/polygon.sql modified +4 −87

Discussion