Horton

Use XLogRecPtrIsValid() in various places

Álvaro Herrera <alvherre@kurilemu.de>

View on postgr.es
Commit: a2b02293bc65dbb2401cb19c724f52c6ee0f2faf
Author: Álvaro Herrera <alvherre@kurilemu.de>
Date: 2025-11-06T19:33:57Z
Releases: 19 (unreleased) 
Use XLogRecPtrIsValid() in various places

Now that commit 06edbed47862 has introduced XLogRecPtrIsValid(), we can
use that instead of:

- XLogRecPtrIsInvalid()
- direct comparisons with InvalidXLogRecPtr
- direct comparisons with literal 0

This makes the code more consistent.

Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal

Files

PathChange+/−
contrib/pg_walinspect/pg_walinspect.c modified +2 −2
src/backend/access/gist/gist.c modified +2 −2
src/backend/access/gist/gistget.c modified +2 −2
src/backend/access/gist/gistutil.c modified +1 −1
src/backend/access/heap/rewriteheap.c modified +2 −2
src/backend/access/heap/vacuumlazy.c modified +1 −1
src/backend/access/heap/visibilitymap.c modified +2 −2
src/backend/access/transam/clog.c modified +3 −2
src/backend/access/transam/slru.c modified +1 −1
src/backend/access/transam/timeline.c modified +2 −2
src/backend/access/transam/twophase.c modified +3 −3
src/backend/access/transam/xlogbackup.c modified +2 −2
src/backend/access/transam/xlog.c modified +24 −24
src/backend/access/transam/xlogfuncs.c modified +2 −2
src/backend/access/transam/xloginsert.c modified +2 −2
src/backend/access/transam/xlogreader.c modified +4 −4
src/backend/access/transam/xlogrecovery.c modified +10 −10
src/backend/access/transam/xlogutils.c modified +4 −4
src/backend/access/transam/xlogwait.c modified +1 −1
src/backend/backup/backup_manifest.c modified +2 −2
src/backend/backup/basebackup_incremental.c modified +1 −1
src/backend/backup/walsummary.c modified +4 −4
src/backend/catalog/pg_subscription.c modified +2 −2
src/backend/commands/subscriptioncmds.c modified +3 −3
src/backend/postmaster/walsummarizer.c modified +9 −9
src/backend/replication/logical/applyparallelworker.c modified +2 −2
src/backend/replication/logical/launcher.c modified +2 −2
src/backend/replication/logical/logical.c modified +16 −16
src/backend/replication/logical/logicalfuncs.c modified +3 −3
src/backend/replication/logical/origin.c modified +9 −9
src/backend/replication/logical/proto.c modified +9 −9
src/backend/replication/logical/reorderbuffer.c modified +19 −19
src/backend/replication/logical/slotsync.c modified +3 −3
src/backend/replication/logical/snapbuild.c modified +7 −7
src/backend/replication/logical/worker.c modified +8 −8
src/backend/replication/slot.c modified +14 −14
src/backend/replication/slotfuncs.c modified +11 −11
src/backend/replication/syncrep.c modified +5 −5
src/backend/replication/walreceiver.c modified +4 −4
src/backend/replication/walreceiverfuncs.c modified +1 −1
src/backend/replication/walsender.c modified +15 −15
src/backend/storage/buffer/bufmgr.c modified +1 −1
src/bin/pg_basebackup/pg_receivewal.c modified +4 −4
src/bin/pg_basebackup/pg_recvlogical.c modified +6 −6
src/bin/pg_rewind/pg_rewind.c modified +2 −2
src/bin/pg_waldump/pg_waldump.c modified +7 −7

Discussion