Fix contrib/pageinspect to not create an ABI breakage between 8.3 and 8.4.
Tom Lane <tgl@sss.pgh.pa.us>
Fix contrib/pageinspect to not create an ABI breakage between 8.3 and 8.4. The original implementation of the 3-argument form of get_raw_page() risked core dumps if the 8.3 SQL function definition was mistakenly used with the 8.4 module, which is entirely likely after a dump-and-reload upgrade. To protect 8.4 beta testers against upgrade problems, add a check on PG_NARGS. In passing, fix missed additions to the uninstall script, and polish the docs a trifle.
Files
| Path | Change | +/− |
|---|---|---|
| contrib/pageinspect/pageinspect.sql.in | modified | +5 −5 |
| contrib/pageinspect/rawpage.c | modified | +52 −6 |
| contrib/pageinspect/uninstall_pageinspect.sql | modified | +3 −1 |
| doc/src/sgml/pageinspect.sgml | modified | +7 −5 |