Horton

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

Andres Freund <andres@anarazel.de>

View on postgr.es
Commit: 9ff7fd9063ce918e458a643b53eda1cf95f7d115
Author: Andres Freund <andres@anarazel.de>
Date: 2022-02-25T18:31:16Z
Releases: 14.3 
pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Files

PathChange+/−
src/bin/pg_waldump/pg_waldump.c modified +5 −8

Discussion