Horton

Replace many MemSet calls with struct initialization

Peter Eisentraut <peter@eisentraut.org>

View on postgr.es
Commit: 9fd45870c1436b477264c0c82eb195df52bc0919
Author: Peter Eisentraut <peter@eisentraut.org>
Date: 2022-07-16T06:50:49Z
Releases: 16.0 
Replace many MemSet calls with struct initialization

This replaces all MemSet() calls with struct initialization where that
is easily and obviously possible.  (For example, some cases have to
worry about padding bits, so I left those.)

(The same could be done with appropriate memset() calls, but this
patch is part of an effort to phase out MemSet(), so it doesn't touch
memset() calls.)

Reviewed-by: Ranier Vilela <ranier.vf@gmail.com>
Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/9847b13c-b785-f4e2-75c3-12ec77a3b05c@enterprisedb.com

Files

PathChange+/−
contrib/amcheck/verify_heapam.c modified +2 −4
contrib/bloom/blcost.c modified +1 −3
contrib/pageinspect/brinfuncs.c modified +2 −5
contrib/pageinspect/hashfuncs.c modified +4 −12
contrib/pageinspect/heapfuncs.c modified +2 −6
contrib/pg_prewarm/autoprewarm.c modified +2 −4
contrib/pg_stat_statements/pg_stat_statements.c modified +2 −5
contrib/pgstattuple/pgstatindex.c modified +1 −2
contrib/pg_visibility/pg_visibility.c modified +5 −10
contrib/pg_walinspect/pg_walinspect.c modified +7 −18
contrib/postgres_fdw/connection.c modified +2 −5
contrib/postgres_fdw/postgres_fdw.c modified +1 −2
src/backend/access/transam/twophase.c modified +2 −4
src/backend/access/transam/xlogfuncs.c modified +2 −5
src/backend/catalog/aclchk.c modified +44 −102
src/backend/catalog/dependency.c modified +1 −2
src/backend/catalog/heap.c modified +7 −17
src/backend/catalog/index.c modified +1 −3
src/backend/catalog/pg_attrdef.c modified +3 −6
src/backend/catalog/pg_cast.c modified +1 −3
src/backend/catalog/pg_parameter_acl.c modified +2 −4
src/backend/catalog/pg_publication.c modified +2 −4
src/backend/commands/dbcommands.c modified +11 −24
src/backend/commands/event_trigger.c modified +3 −8
src/backend/commands/functioncmds.c modified +2 −5
src/backend/commands/prepare.c modified +1 −3
src/backend/commands/tablecmds.c modified +14 −30
src/backend/commands/tablespace.c modified +1 −3
src/backend/commands/typecmds.c modified +3 −6
src/backend/commands/user.c modified +11 −26
src/backend/optimizer/path/costsize.c modified +1 −2
src/backend/parser/parse_target.c modified +1 −2
src/backend/replication/logical/launcher.c modified +2 −5
src/backend/replication/walsender.c modified +6 −11
src/backend/rewrite/rewriteDefine.c modified +3 −5
src/backend/utils/adt/acl.c modified +1 −3
src/backend/utils/adt/arrayfuncs.c modified +1 −2
src/backend/utils/adt/datetime.c modified +2 −6
src/backend/utils/adt/lockfuncs.c modified +4 −8
src/backend/utils/adt/partitionfuncs.c modified +2 −4
src/backend/utils/adt/pgstatfuncs.c modified +14 −38
src/backend/utils/adt/selfuncs.c modified +5 −14
src/backend/utils/adt/timestamp.c modified +3 −5
src/backend/utils/mmgr/portalmem.c modified +1 −3
src/bin/pg_basebackup/pg_basebackup.c modified +4 −9
src/bin/pg_basebackup/pg_receivewal.c modified +1 −3
src/bin/pg_basebackup/walmethods.c modified +2 −4
src/common/ip.c modified +1 −3
src/port/snprintf.c modified +2 −6
src/test/modules/test_predtest/test_predtest.c modified +1 −2
src/test/regress/regress.c modified +1 −2

Discussion