Remove some more "snapshot too old" vestiges.
Thomas Munro <tmunro@postgresql.org>
Remove some more "snapshot too old" vestiges. Commit f691f5b8 removed the logic, but left behind some now-useless Snapshot arguments to various AM-internal functions, and missed a couple of comments. Reported-by: Peter Geoghegan <pg@bowt.ie> Discussion: https://postgr.es/m/CAH2-Wznj9qSNXZ1P1uWTUD_FeaTezbUazb416EPwi4Qr_jR_6A%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| contrib/amcheck/verify_nbtree.c | modified | +1 −1 |
| src/backend/access/brin/brin.c | modified | +9 −12 |
| src/backend/access/brin/brin_revmap.c | modified | +3 −5 |
| src/backend/access/common/toast_internals.c | modified | +1 −2 |
| src/backend/access/gin/ginbtree.c | modified | +1 −1 |
| src/backend/access/gin/gindatapage.c | modified | +3 −4 |
| src/backend/access/gin/ginget.c | modified | +13 −15 |
| src/backend/access/gin/gininsert.c | modified | +1 −1 |
| src/backend/access/heap/vacuumlazy.c | modified | +0 −4 |
| src/backend/access/nbtree/nbtinsert.c | modified | +2 −2 |
| src/backend/access/nbtree/nbtpage.c | modified | +1 −2 |
| src/backend/access/nbtree/nbtsearch.c | modified | +11 −24 |
| src/backend/access/spgist/spgscan.c | modified | +3 −4 |
| src/include/access/brin_revmap.h | modified | +2 −2 |
| src/include/access/gin_private.h | modified | +2 −2 |
| src/include/access/nbtree.h | modified | +3 −4 |
Discussion
- old_snapshot_threshold bottleneck on replica 16 messages · 2023-01-23 → 2023-09-08