Correct comment and some documentation about REPLICA_IDENTITY_INDEX

Michael Paquier <michael@paquier.xyz>

Commit: 9edca4cb57d240a196403c805dfa92686954d155
Author: Michael Paquier <michael@paquier.xyz>
Date: 2021-12-22T07:38:58Z
Releases: 10.20
Correct comment and some documentation about REPLICA_IDENTITY_INDEX

catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT.  The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.

The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.

While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.

Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com
Backpatch-through: 10

Files

PathChange+/−
doc/src/sgml/ref/alter_table.sgml modified +43 −8
src/include/catalog/pg_class.h modified +1 −1

Documentation touched

Discussion