Horton

Refactor cluster_rel() to handle more options

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 9ebe0572ceab69c57811746ead2d3418daea8673
Author: Michael Paquier <michael@paquier.xyz>
Date: 2018-07-24T02:37:32Z
Releases: 12.0 
Refactor cluster_rel() to handle more options

This extends cluster_rel() in such a way that more options can be added
in the future, which will reduce the amount of chunk code for an
upcoming SKIP_LOCKED aimed for VACUUM.  As VACUUM FULL is a different
flavor of CLUSTER, we want to make that extensible to ease integration.

This only reworks the API and its callers, without providing anything
user-facing.  Two options are present now: verbose mode and relation
recheck when doing the cluster command work across multiple
transactions.  This could be used as well as a base to extend the
grammar of CLUSTER later on.

Author: Michael Paquier
Reviewed-by: Nathan Bossart
Discussion: https://postgr.es/m/20180723031058.GE2854@paquier.xyz

Files

PathChange+/−
src/backend/commands/cluster.c modified +6 −3
src/backend/commands/vacuum.c modified +6 −2
src/backend/nodes/copyfuncs.c modified +1 −1
src/backend/nodes/equalfuncs.c modified +1 −1
src/backend/parser/gram.y modified +9 −3
src/include/commands/cluster.h modified +1 −2
src/include/nodes/parsenodes.h modified +7 −1
src/tools/pgindent/typedefs.list modified +1 −0

Discussion