Fix TestLib::slurp_file() with offset on windows.

Andres Freund <andres@anarazel.de>

Commit: 9e3be5c182d71d7575aa2e63d9604bfa715a432e
Author: Andres Freund <andres@anarazel.de>
Date: 2021-10-04T20:33:41Z
Releases: 9.6.24
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Files

PathChange+/−
src/test/perl/TestLib.pm modified +18 −18

Discussion