Recommend wrappers of PG_DETOAST_DATUM_PACKED().
Noah Misch <noah@leadboat.com>
Recommend wrappers of PG_DETOAST_DATUM_PACKED(). When commit 3e23b68dac006e8deb0afa327e855258df8de064 introduced single-byte varlena headers, its fmgr.h changes presented PG_GETARG_TEXT_PP() and PG_GETARG_TEXT_P() as equals. Its postgres.h changes presented PG_DETOAST_DATUM_PACKED() and VARDATA_ANY() as the exceptional case. Now, instead, firmly recommend PG_GETARG_TEXT_PP() over PG_GETARG_TEXT_P(); likewise for other ...PP() macros. This shaves cycles and invites consistency of style.
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/xfunc.sgml | modified | +19 −13 |
| src/include/c.h | modified | +5 −4 |
| src/include/fmgr.h | modified | +21 −13 |
| src/include/postgres.h | modified | +12 −14 |
| src/include/utils/inet.h | modified | +3 −2 |
| src/tutorial/funcs_new.c | modified | +16 −13 |