Horton

Revert "Catalog NOT NULL constraints" and fallout

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 9ce04b50e120275afbc03ca0b80839dde3da8308
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-04-12T17:29:21Z
Releases: 16.0 
Revert "Catalog NOT NULL constraints" and fallout

This reverts commit e056c557aef4 and minor later fixes thereof.

There's a few problems in this new feature -- most notably regarding
pg_upgrade behavior, but others as well.  This new feature is not in any
way critical on its own, so instead of scrambling to fix it we revert it
and try again in early 17 with these issues in mind.

Discussion: https://postgr.es/m/3801207.1681057430@sss.pgh.pa.us

Files

PathChange+/−
doc/src/sgml/catalogs.sgml modified +0 −1
doc/src/sgml/ref/alter_table.sgml modified +3 −11
doc/src/sgml/ref/create_table.sgml modified +7 −1
src/backend/catalog/heap.c modified +99 −392
src/backend/catalog/pg_constraint.c modified +0 −97
src/backend/commands/tablecmds.c modified +329 −997
src/backend/nodes/outfuncs.c modified +0 −4
src/backend/nodes/readfuncs.c modified +1 −7
src/backend/optimizer/util/plancat.c modified +0 −2
src/backend/parser/gram.y modified +0 −13
src/backend/parser/parse_utilcmd.c modified +55 −151
src/backend/utils/adt/ruleutils.c modified +0 −14
src/bin/pg_dump/common.c modified +6 −9
src/bin/pg_dump/pg_backup_archiver.c modified +0 −2
src/bin/pg_dump/pg_dump.c modified +27 −182
src/bin/pg_dump/pg_dump.h modified +1 −1
src/bin/pg_dump/t/002_pg_dump.pl modified +3 −3
src/include/catalog/catversion.h modified +1 −1
src/include/catalog/heap.h modified +2 −5
src/include/catalog/pg_constraint.h modified +3 −8
src/include/commands/tablecmds.h modified +0 −2
src/include/nodes/parsenodes.h modified +4 −10
src/test/modules/test_ddl_deparse/expected/alter_table.out modified +11 −7
src/test/modules/test_ddl_deparse/expected/create_table.out modified +1 −24
src/test/modules/test_ddl_deparse/test_ddl_deparse.c modified +0 −4
src/test/regress/expected/alter_table.out modified +19 −31
src/test/regress/expected/cluster.out modified +3 −4
src/test/regress/expected/constraints.out modified +0 −114
src/test/regress/expected/create_table.out modified +12 −15
src/test/regress/expected/event_trigger.out modified +0 −2
src/test/regress/expected/foreign_data.out modified +5 −6
src/test/regress/expected/foreign_key.out modified +2 −14
src/test/regress/expected/indexing.out modified +15 −26
src/test/regress/expected/inherit.out modified +0 −408
src/test/regress/expected/replica_identity.out modified +0 −13
src/test/regress/parallel_schedule modified +1 −2
src/test/regress/sql/alter_table.sql modified +9 −17
src/test/regress/sql/constraints.sql modified +0 −43
src/test/regress/sql/create_table.sql modified +3 −3
src/test/regress/sql/indexing.sql modified +3 −5
src/test/regress/sql/inherit.sql modified +0 −211
src/test/regress/sql/replica_identity.sql modified +0 −12

Documentation touched

Discussion