Fix failure to handle conflicts in non-arbiter exclusion constraints.
Tom Lane <tgl@sss.pgh.pa.us>
Fix failure to handle conflicts in non-arbiter exclusion constraints. ExecInsertIndexTuples treated an exclusion constraint as subject to noDupErr processing even when it was not listed in arbiterIndexes, and would therefore not error out for a conflict in such a constraint, instead returning it as an arbiter-index failure. That led to an infinite loop in ExecInsert, since ExecCheckIndexConstraints ignored the index as-intended and therefore didn't throw the expected error. To fix, make the exclusion constraint code path use the same condition as the index_insert call does to decide whether no-error-for-duplicates behavior is appropriate. While at it, refactor a little bit to avoid unnecessary list_member_oid calls. (That surely wouldn't save anything worth noticing, but I find the code a bit clearer this way.) Per bug report from Heikki Rauhala. Back-patch to 9.5 where ON CONFLICT was introduced. Report: <4C976D6B-76B4-434C-8052-D009F7B7AEDA@reaktor.fi>
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/executor/execIndexing.c | modified | +12 −7 |
| src/test/regress/expected/insert_conflict.out | modified | +23 −0 |
| src/test/regress/sql/insert_conflict.sql | modified | +14 −0 |