Horton

Remove block number field from nbtree stack.

Peter Geoghegan <pg@bowt.ie>

View on postgr.es
Commit: 9c02cf56614366769682bb8b3f4e9eecf8f237c4
Author: Peter Geoghegan <pg@bowt.ie>
Date: 2019-08-14T18:32:35Z
Releases: 13.0 
Remove block number field from nbtree stack.

The initial value of the nbtree stack downlink block number field
recorded during an initial descent of the tree wasn't actually used.
Both _bt_getstackbuf() callers overwrote the value with their own value.

Remove the block number field from the stack struct, and add a child
block number argument to _bt_getstackbuf() in its place.  This makes the
overall design of _bt_getstackbuf() clearer.

Author: Peter Geoghegan
Reviewed-By: Anastasia Lubennikova
Discussion: https://postgr.es/m/CAH2-Wzmx+UbXt2YNOUCZ-a04VdXU=S=OHuAuD7Z8uQq-PXTYUg@mail.gmail.com

Files

PathChange+/−
src/backend/access/nbtree/nbtinsert.c modified +30 −16
src/backend/access/nbtree/nbtpage.c modified +1 −2
src/backend/access/nbtree/nbtsearch.c modified +6 −13
src/backend/access/nbtree/README modified +7 −1
src/include/access/nbtree.h modified +6 −10

Discussion