Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name.
Tom Lane <tgl@sss.pgh.pa.us>
Reject "ALTER DATABASE/USER ... RESET foo" with invalid GUC name. If the database or user had no entry in pg_db_role_setting, RESET silently did nothing --- including not checking the validity of the given GUC name. This is quite inconsistent and surprising, because you *would* get such an error if there were any pg_db_role_setting entry, even though it contains values for unrelated GUCs. While this is clearly a bug, changing it in stable branches seems unwise. The effect will be that some ALTER commands that formerly were no-ops will now be errors, and people don't like that sort of thing in minor releases. Author: Vitaly Davydov <v.davydov@postgrespro.ru> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/30783e-68c28a00-9-41004480@130449754
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/catalog/pg_db_role_setting.c | modified | +9 −0 |
| src/test/modules/unsafe_tests/expected/setconfig.out | modified | +13 −0 |
| src/test/modules/unsafe_tests/sql/setconfig.sql | modified | +9 −0 |
Discussion
- ALTER DATABASE RESET with unexistent guc doesn't report an error 6 messages · 2025-09-11 → 2025-09-12