There's a patch attached to fix gcc 2.8.x warnings, except for the
Bruce Momjian <bruce@momjian.us>
There's a patch attached to fix gcc 2.8.x warnings, except for the yyerror ones from bison. It also includes a few 'enhancements' to the C programming style (which are, of course, personal). The other patch removes the compilation of backend/lib/qsort.c, as qsort() is a standard function in stdlib.h and can be used any where else (and it is). It was only used in backend/optimizer/geqo/geqo_pool.c, backend/optimizer/path/predmig.c, and backend/storage/page/bufpage.c > > Some or all of these changes might not be appropriate for v6.3, since we > > are in beta testing and since they do not affect the current functionality. > > For those cases, how about submitting patches based on the final v6.3 > > release? There's more to come. Please review these patches. I ran the regression tests and they only failed where this was expected (random, geo, etc). Cheers, Jeroen
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/copy.c | modified | +3 −1 |
| src/backend/commands/sequence.c | modified | +6 −0 |
| src/backend/commands/variable.c | modified | +4 −2 |
| src/backend/executor/nodeIndexscan.c | modified | +36 −52 |
| src/backend/executor/nodeSeqscan.c | modified | +3 −5 |
| src/backend/lib/Makefile | modified | +2 −2 |
| src/backend/libpq/be-dumpdata.c | modified | +3 −1 |
| src/backend/lib/qsort.c | deleted | +0 −312 |
| src/backend/optimizer/geqo/geqo_pool.c | modified | +2 −5 |
| src/backend/optimizer/path/joinrels.c | modified | +3 −1 |
| src/backend/optimizer/path/predmig.c | modified | +2 −3 |
| src/backend/parser/analyze.c | modified | +3 −1 |
| src/backend/postmaster/postmaster.c | modified | +5 −2 |
| src/backend/storage/page/bufpage.c | modified | +2 −4 |
| src/backend/utils/adt/arrayfuncs.c | modified | +5 −3 |
| src/bin/pg_dump/pg_dump.c | modified | +5 −1 |
| src/bin/pg_version/pg_version.c | modified | +2 −2 |