Produce a more useful error message for over-length Unix socket paths.
Tom Lane <tgl@sss.pgh.pa.us>
Produce a more useful error message for over-length Unix socket paths. The length of a socket path name is constrained by the size of struct sockaddr_un, and there's not a lot we can do about it since that is a kernel API. However, it would be a good thing if we produced an intelligible error message when the user specifies a socket path that's too long --- and getaddrinfo's standard API is too impoverished to do this in the natural way. So insert explicit tests at the places where we construct a socket path name. Now you'll get an error that makes sense and even tells you what the limit is, rather than something generic like "Non-recoverable failure in name resolution". Per trouble report from Jeremy Drake and a fix idea from Andrew Dunstan.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/libpq/pqcomm.c | modified | +8 −0 |
| src/include/libpq/pqcomm.h | modified | +13 −0 |
| src/interfaces/libpq/fe-connect.c | modified | +10 −1 |