Horton

Fix harmless leftover in _hash_kill_items()

Heikki Linnakangas <heikki.linnakangas@iki.fi>

View on postgr.es
Commit: 979387f1885111c72b84af535f23de4e3e913206
Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: 2026-04-07T14:38:11Z
Releases: 19 (unreleased) 
Fix harmless leftover in _hash_kill_items()

Checking for 'havePin' is sufficient here. An earlier version of the
patch didn't have the 'havePin' variable and used
'so->hashso_bucket_buf == so->currPos.buf' as the condition when both
locking and unlocking the page. The havePin variable was added later
during development, but the unlocking condition wasn't fully
updated. Tidy it up.

Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/b9de8d05-3b02-4a27-9b0b-03972fa4bfd3@iki.fi

Files

PathChange+/−
src/backend/access/hash/hashutil.c modified +1 −2

Discussion