Change array_offset to return subscripts, not offsets

Alvaro Herrera <alvherre@alvh.no-ip.org>

Commit: 97690ea6e86c412461dd5dc99953b829564d1a55
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2015-03-30T19:13:21Z
Releases: 9.5.0
Change array_offset to return subscripts, not offsets

... and rename it and its sibling array_offsets to array_position and
array_positions, to account for the changed behavior.

Having the functions return subscripts better matches existing practice,
and is better suited to using the result value as a subscript into the
array directly.  For one-based arrays, the new definition is identical
to what was originally committed.

(We use the term "subscript" in the documentation, which is what we use
whenever we talk about arrays; but the functions themselves are named
using the word "position" to match the standard-defined POSITION()
functions.)

Author: Pavel Stěhule
Behavioral problem noted by Dean Rasheed.

Files