Fix off_t overflow in pg_basebackup on Windows.
Thomas Munro <tmunro@postgresql.org>
Fix off_t overflow in pg_basebackup on Windows. walmethods.c used off_t to navigate around a pg_wal.tar file that could exceed 2GB, which doesn't work on Windows and would fail with misleading errors. Use pgoff_t instead. Back-patch to all supported branches. Author: Davinder Singh <davinder.singh@enterprisedb.com> Reported-by: Jakub Wartak <jakub.wartak@enterprisedb.com> Discussion: https://postgr.es/m/CAKZiRmyM4YnokK6Oenw5JKwAQ3rhP0YTz2T-tiw5dAQjGRXE3Q%40mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_basebackup/receivelog.c | modified | +1 −1 |
| src/bin/pg_basebackup/walmethods.c | modified | +1 −1 |
| src/bin/pg_basebackup/walmethods.h | modified | +1 −1 |
Discussion
- Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes) 17 messages · 2024-11-21 → 2025-01-09