Horton

Detect unused steps in isolation specs and do some cleanup

Michael Paquier <michael@paquier.xyz>

View on postgr.es
Commit: 96f3661e4540db1f45709c5f098aeecc6e9df271
Author: Michael Paquier <michael@paquier.xyz>
Date: 2021-06-17T02:57:21Z
Releases: 12.8 
Detect unused steps in isolation specs and do some cleanup

This is useful for developers to find out if an isolation spec is
over-engineered or if it needs more work by warning at the end of a
test run if a step is not used, generating a failure with extra diffs.

While on it, clean up all the specs which include steps not used in any
permutations to simplify them.

This is a backpatch of 989d23b and 06fdc4e, as it is becoming useful to
make all the branches consistent for an upcoming patch that will improve
the output generated by isolationtester.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz
Discussion: https://postgr.es/m/794820.1623872009@sss.pgh.pa.us
Backpatch-through: 9.6

Files

PathChange+/−
contrib/test_decoding/specs/concurrent_ddl_dml.spec modified +0 −9
contrib/test_decoding/specs/snapshot_transfer.spec modified +0 −1
src/test/isolation/expected/eval-plan-qual-trigger.out modified +1 −1
src/test/isolation/isolationtester.c modified +18 −1
src/test/isolation/isolationtester.h modified +1 −0
src/test/isolation/specparse.y modified +1 −0
src/test/isolation/specs/eval-plan-qual-trigger.spec modified +19 −19
src/test/isolation/specs/freeze-the-dead.spec modified +0 −3
src/test/isolation/specs/insert-conflict-do-nothing.spec modified +0 −1
src/test/isolation/specs/insert-conflict-do-update-2.spec modified +0 −1
src/test/isolation/specs/insert-conflict-do-update.spec modified +0 −1
src/test/isolation/specs/sequence-ddl.spec modified +0 −1
src/test/isolation/specs/tuplelock-upgrade-no-deadlock.spec modified +0 −3

Discussion