Fix duplicate transaction replay during pg_createsubscriber.
Amit Kapila <akapila@postgresql.org>
Fix duplicate transaction replay during pg_createsubscriber. Previously, the tool could replay the same transaction twice, once during recovery, then again during replication after the subscriber was set up. This occurred because the same recovery_target_lsn was used both to finalize recovery and to start replication. If recovery_target_inclusive = true, the transaction at that LSN would be applied during recovery and then sent again by the publisher leading to duplication. To prevent this, we now set recovery_target_inclusive = false. This ensures the transaction at recovery_target_lsn is not reapplied during recovery, avoiding duplication when replication begins. Bug #18897 Reported-by: Zane Duffield <duffieldzane@gmail.com> Author: Shlok Kyal <shlok.kyal.oss@gmail.com> Reviewed-by: vignesh C <vignesh21@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 17, where it was introduced Discussion: https://postgr.es/m/18897-d3db67535860dddb@postgresql.org
Files
| Path | Change | +/− |
|---|---|---|
| src/bin/pg_basebackup/pg_createsubscriber.c | modified | +10 −1 |
Discussion
- BUG #18897: Logical replication conflict after using pg_createsubscriber under heavy load 26 messages · 2025-04-16 → 2025-07-24