Fix GiST buffering build to work when there are included columns.
Tom Lane <tgl@sss.pgh.pa.us>
Fix GiST buffering build to work when there are included columns. gistRelocateBuildBuffersOnSplit did not get the memo about which attribute count to use. This could lead to a crash if there were included columns and buffering build was chosen. (Because there are random page-split decisions elsewhere in GiST index build, the crashes are not entirely deterministic.) Back-patch to v12 where GiST gained support for included columns. Pavel Borisov Discussion: https://postgr.es/m/CALT9ZEECCV5m7wvxg46PC-7x-EybUmnpupBGhSFMoAAay+r6HQ@mail.gmail.com
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/access/gist/gistbuildbuffers.c | modified | +2 −2 |
Discussion
- BUG #16329: Valgrind detects an invalid read when building a gist index with buffering 20 messages · 2020-03-29 → 2023-03-30