pg_upgrade: Default new bindir to pg_upgrade location
Peter Eisentraut <peter@eisentraut.org>
pg_upgrade: Default new bindir to pg_upgrade location Make the directory where the pg_upgrade binary resides the default for new bindir, as running the pg_upgrade binary from where the new cluster is installed is a very common scenario. Setting this as the defauly bindir for the new cluster will remove the need to provide it explicitly via -B in many cases. To support directories being missing from option parsing, extend the directory check with a missingOk mode where the path must be filled at a later point before being used. Also move the exec_path check to earlier in setup to make sure we know the new cluster bindir when we scan for required executables. This removes the exec_path from the OSInfo struct as it is not used anywhere. Author: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Peter Eisentraut <peter.eisentraut@2ndquadrant.com> Discussion: https://www.postgresql.org/message-id/flat/9328.1552952117@sss.pgh.pa.us
Files
| Path | Change | +/− |
|---|---|---|
| doc/src/sgml/ref/pgupgrade.sgml | modified | +1 −0 |
| src/bin/pg_upgrade/option.c | modified | +14 −8 |
| src/bin/pg_upgrade/pg_upgrade.c | modified | +17 −11 |
| src/bin/pg_upgrade/pg_upgrade.h | modified | +0 −1 |
| src/bin/pg_upgrade/test.sh | modified | +1 −1 |
| src/tools/msvc/vcregress.pl | modified | +1 −1 |
Documentation touched
Discussion
- pg_upgrade version checking questions 25 messages · 2019-03-18 → 2021-03-03