Consolidate and improve checking of key-column-attnum arguments for

Tom Lane <tgl@sss.pgh.pa.us>

Commit: 9486eeb714090ea1f3c3451e618ad1f4ec1c8f47
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: 2010-06-15T16:22:26Z
Releases: 8.4.5
Consolidate and improve checking of key-column-attnum arguments for
dblink_build_sql_insert() and related functions.  In particular, be sure to
reject references to dropped and out-of-range column numbers.  The numbers
are still interpreted as physical column numbers, though, for backward
compatibility.

This patch replaces Joe's patch of 2010-02-03, which handled only some aspects
of the problem.

Files

PathChange+/−
contrib/dblink/dblink.c modified +89 −118
contrib/dblink/expected/dblink.out modified +3 −3