Horton

Revert "Avoid spurious deadlocks when upgrading a tuple lock"

Alvaro Herrera <alvherre@alvh.no-ip.org>

View on postgr.es
Commit: 93d4484ef80aa4df04f70348fd34d45d2eb85416
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2019-06-17T02:24:20Z
Releases: 10.9 
Revert "Avoid spurious deadlocks when upgrading a tuple lock"

This reverts commits 3da73d6839dc and de87a084c0a5.

This code has some tricky corner cases that I'm not sure are correct and
not properly tested anyway, so I'm reverting the whole thing for next
week's releases (reintroducing the deadlock bug that we set to fix).
I'll try again afterwards.

Discussion: https://postgr.es/m/E1hbXKQ-0003g1-0C@gemulon.postgresql.org

Files

PathChange+/−
src/backend/access/heap/heapam.c modified +21 −62
src/backend/access/heap/README.tuplock modified +0 −10
src/test/isolation/expected/tuplelock-upgrade-no-deadlock.out deleted +0 −150
src/test/isolation/isolation_schedule modified +0 −1
src/test/isolation/specs/tuplelock-upgrade-no-deadlock.spec deleted +0 −57

Discussion