Eliminate divide in new fast-path locking code

David Rowley <drowley@postgresql.org>

Commit: 936457419d797dfaf37191db53d5efb1279eae6d
Author: David Rowley <drowley@postgresql.org>
Date: 2025-04-26T23:53:40Z
Releases: 18.0
Eliminate divide in new fast-path locking code

c4d5cb71d2 adjusted the fast-path locking code to allow some
configuration of the number of fast-path locking slots via the
max_locks_per_transaction GUC.  In that commit the FAST_PATH_REL_GROUP()
macro used integer division to determine the fast-path locking group slot
to use for the lock.

The divisor in this case is always a power-of-two value.  Here we swap
out the divide by a bitwise-AND, which is a significantly faster
operation to perform.

In passing, adjust the code that's setting FastPathLockGroupsPerBackend
so that it's more clear that the value being set is a power-of-two.

Also, adjust some comments in the area which contained some magic
numbers.  It seems better to justify the 1024 upper limit in the
location where the #define is made instead of where it is used.

Author: David Rowley <drowleyml@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/CAApHDvodr3bcnpxcs7+k-3cFwYR0tP-BYhyd2PpDhe-bCx9i=g@mail.gmail.com

Files

PathChange+/−
src/backend/storage/lmgr/lock.c modified +4 −1
src/backend/utils/init/postinit.c modified +15 −19
src/include/storage/proc.h modified +8 −0

Discussion