psql: Fix some strange code in SQL help creation

Peter Eisentraut <peter_e@gmx.net>

Commit: 92d4294d4bbddf94cec0dce729ade7bb2aada1b7
Author: Peter Eisentraut <peter_e@gmx.net>
Date: 2016-03-09T00:41:51Z
Releases: 9.6.0
psql: Fix some strange code in SQL help creation

Struct QL_HELP used to be defined as static in the sql_help.h header
file, which is included in sql_help.c and help.c, thus creating two
separate instances of the struct.  This causes a warning from GCC 6,
because the struct is not used in sql_help.c.

Instead, declare the struct as extern in the header file and define it
in sql_help.c.  This also allows making a bunch of functions static
because they are no longer needed outside of sql_help.c.

Reviewed-by: Thomas Munro <thomas.munro@enterprisedb.com>

Files

PathChange+/−
src/bin/psql/create_help.pl modified +10 −10