Fix broken dependency-mongering for index operator classes/families.
Tom Lane <tgl@sss.pgh.pa.us>
Fix broken dependency-mongering for index operator classes/families. For a long time, opclasscmds.c explained that "we do not create a dependency link to the AM [for an opclass or opfamily], because we don't currently support DROP ACCESS METHOD". Commit 473b93287040b200 invented DROP ACCESS METHOD, but it batted only 1 for 2 on adding the dependency links, and 0 for 2 on updating the comments about the topic. In passing, undo the same commit's entirely inappropriate decision to blow away an existing index as a side-effect of create_am.sql.
Files
| Path | Change | +/− |
|---|---|---|
| src/backend/commands/opclasscmds.c | modified | +9 −12 |
| src/test/regress/expected/create_am.out | modified | +15 −20 |
| src/test/regress/expected/sanity_check.out | modified | +1 −1 |
| src/test/regress/sql/create_am.sql | modified | +9 −12 |