Simplify gettimeofday() fallback logic.

Andres Freund <andres@anarazel.de>

Commit: 922a8fa098404cbd5c6089e78eca4aebd828f847
Author: Andres Freund <andres@anarazel.de>
Date: 2022-08-06T15:34:56Z
Releases: 16.0
Simplify gettimeofday() fallback logic.

There's no known supported system needing 1 argument gettimeofday()
support. The test for it was added a long time ago (92c6bf9775b). Remove.

Until now we tested whether a gettimeofday() fallback is needed when
targetting windows. Which lead to the odd result that HAVE_GETTIMEOFDAY only
being defined when targetting MinGW (which has gettimeofday() since at least
2007). As the fallback is specific to msvc, remove the configure code and
rename src/port/gettimeofday.c to src/port/win32gettimeofday.c.

While at it, also remove the definition of struct timezone, a forward
declaration of the struct is sufficient.

Reviewed-By: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-By: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/20220806000311.ywx65iuchvj4qn2k@awork3.anarazel.de

Files

PathChange+/−
config/c-library.m4 modified +0 −24
configure modified +0 −47
configure.ac modified +0 −2
src/include/pg_config.h.in modified +0 −10
src/include/port.h modified +0 −5
src/include/port/win32_port.h modified +5 −10
src/port/win32gettimeofday.c (from src/port/gettimeofday.c) renamed +2 −2
src/tools/msvc/Mkvcbuild.pm modified +2 −1
src/tools/msvc/Solution.pm modified +0 −2

Discussion