xml2: Fix crash with namespace nodes in xpath_nodeset()
Michael Paquier <michael@paquier.xyz>
xml2: Fix crash with namespace nodes in xpath_nodeset() pgxmlNodeSetToText() passed nodeTab[i]->doc to xmlNodeDump() without checking the node type, which could cause a crash as a XML_NAMESPACE_DECL maps to a xmlNs struct. The passed-in code would then be dereferenced in xmlNodeDump(). This commit switches the code to render XML_NAMESPACE_DECL nodes with xmlXPathCastNodeToString(), like xpath_table(). Some tests are added, written by me. Author: Andrey Chernyy <andrey.cherny@tantorlabs.com> Co-authored-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/20260611031436.5afde3cb@andrnote Backpatch-through: 14
Files
| Path | Change | +/− |
|---|---|---|
| contrib/xml2/expected/xml2_1.out | modified | +8 −0 |
| contrib/xml2/expected/xml2.out | modified | +8 −0 |
| contrib/xml2/sql/xml2.sql | modified | +3 −0 |
| contrib/xml2/xpath.c | modified | +11 −4 |
Discussion
- [PATCH] contrib/xml2: backend crash in xpath_nodeset() on the namespace axis 4 messages · 2026-06-11 → 2026-06-12